Require Login for group and event creation page #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eiffelwong1
requested review from
andrelandgraf,
willbeaumont,
CamilingJS,
tonydangblog and
shami-dev
| export async function requireUserSession(request: Request) { | ||
| const session = await getUserSession(request); | ||
| if (!session) { | ||
| return redirect('/login'); |
There was a problem hiding this comment.
Suggested change
| return redirect('/login'); | |
| throw redirect('/login'); |
There was a problem hiding this comment.
tonydangblog
approved these changes
Mar 19, 2024
andrelandgraf
approved these changes
Apr 2, 2024
| @@ -7,6 +7,11 @@ import { Card } from '~/components/ui/containers'; | |||
| import { Input, TextArea } from '~/components/ui/forms'; | |||
| import { Button } from '~/components/ui/button'; | |||
| import { H1 } from '~/components/ui/headers'; | |||
| import { requireUserSession } from '~/modules/session/session.server'; | |||
|
|
|||
| export async function loader({ request }: LoaderFunctionArgs) { | |||
There was a problem hiding this comment.
As a next step, we could also check here that the user has "admin" access to the group before we allow them to create a new event for that group!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (1-2 sentences)
require login for pages that would need access control in the future
Details (reason and description of the changes)
requires login in New group page and New event page