Doc Changes for better coverage on new materials #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -0,0 +1,15 @@ | |||
| # Auth | |||
| SESSION_SECRET="ANY_RANDOM_STRING_HERE" | |||
There was a problem hiding this comment.
Is there a best practice for how long the SESSION_SECRET should be?
There was a problem hiding this comment.
For a secure random string, we could use openssl rand -base64 32
andrelandgraf
previously approved these changes
Apr 16, 2024
Co-authored-by: Tony Dang <tony@tonydang.blog>
andrelandgraf
approved these changes
Apr 23, 2024
tonydangblog
approved these changes
Apr 23, 2024
| @@ -0,0 +1,15 @@ | |||
| # Auth | |||
| SESSION_SECRET="ANY_RANDOM_STRING_HERE" | |||
There was a problem hiding this comment.
For a secure random string, we could use openssl rand -base64 32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @JacobBaqleh1 @kwesibatchelor for joining the session :D
Summary (1-2 sentences)
new documentation for better onboarding of new contributors.
some of our docs are outdated and not obvious on how to get things set up (it's still not the best but a step on a right direction)
Details (reason and description of the changes)
edited readme.md, new .env.example
Alternative implementations (what alternatives were considered and why were they disregarded?) (optional)
some repository uses CONTRIBUTING.md for the more technical information, but I think putting everything in readme is good since the group intended to get people to code more.
also, what's a good way to encourage design contributions?