Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First iteration of adding group image uploads #149

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

andrelandgraf
Copy link
Contributor

@andrelandgraf andrelandgraf commented Apr 23, 2024

Issue: #147

Summary (1-2 sentences)

PR to add file upload to Supabase to the new group form to allow users to upload group cover images.

Details (reason and description of the changes)

As a user, I want to be able to upload a group image that is displayed next to my group information during group creation.

Implementation Details

Since we migrated our database to Supabase, we can now also use the Supabase file upload feature. There are many considerations regarding file uploads, such as file size limitations, server memory limitations, file name uniqueness, etc. In this PR, we implemented a first minimal solution that does not consider file size or server memory yet, which we must update in a future iteration!

Screenshots/Recordings (if applicable)

Screen.Recording.2024-04-22.at.7.28.59.PM.mov

@andrelandgraf andrelandgraf self-assigned this Apr 23, 2024
Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
plan-it-social-web ✅ Ready (Inspect) Visit Preview Apr 23, 2024 2:31am

Copy link
Contributor

@eiffelwong1 eiffelwong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@shami-dev shami-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything's working! Great work!

@tonydangblog tonydangblog merged commit a1223e2 into main Apr 30, 2024
4 checks passed
@tonydangblog tonydangblog deleted the andrelandgraf/supabase-file-upload-mvp branch April 30, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants