using non-NaN values for plotTransectVerticalSection for significant speedup #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ant speedup of plotting logscale data (e.g. chlorophyll / turbidity)
joanpau
pushed a commit
that referenced
this pull request
Dec 4, 2015
The performance of transect section plots seems to be really bad when there are a lot of invalid values (NaN) in the input data. Drastically improve it by filtering them out when calling the scatter plot function. This does not change the final output. Close: #1.
|
The proposed fix is included in the develop branch (a2e8c94), with minor modifications |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the tested dataset (using ascii files), the speedup for the plotting is huge.
With the actual implementation: my setup needed 1607.517981 seconds.
With the here suggested changes: only 231.806831 seconds.
The added lines will select the non NaN data of the cdata. And uses the same indices for the x and ydata (obviously).
The ylimit is then casted to the max of all y data (including nan-data), to visualize the full depth.
Before:
After:
