-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Docker Files #375
Added Docker Files #375
Conversation
vaughngx4
commented
Jul 3, 2022
- Added Docker Files(Initial Commit)
- Have not yet logged in to run full tests - but everything runs
- Added Docker Files(Initial Commit)
- Fixed spelling of placeholders - Added notification service to default set of vars - Mirrored changes in docker init script to match
Fixed PHP config |
Woah, nice! Then only a GitHub action for automated builds, tags and pushes is needed to have official images, right? |
@alexanderadam I presume so, yes :) there is some caching related code in the build script, I should probably comment that out. |
- Commented out local registry caching - Added normal build - Added notary comments
Thank you so much, this is awesome work! I think I'll finally be able to use this. I'd love to see a twitch stream with you testing it out. Thanks Again! |
@jon4short Glad I could help! I haven't had time to figure out creating a user just yet but I will definitely stream an explanation of the result and me testing it out. Actually just found an issue that will prevent mongo from working, will fix it now. |
- Removed static init file - Added init generation to docker build script
Should be sorted. Let me know if you guys run into any issues and I'll fix them as soon as I can. |
- Fixed variable substitution - Added generated init to .gitignore
Please can devs merge this PR, I have more changes to push. If nobody is active enough, I don't mind handling things here. Otherwise I may have to look into making my fork a whole new SocioBoard replacement project. |
Hi sorry for the delay, Thank you very much for support, Let me review it ASAP. |
@sureshbabu1995 Thanks! Sorry for rushing you. Was beginning to think the project was abandoned. I understand there is a slight language barrier and I don't mind helping out. Will keep in touch. |
After this PR merges I have the admin fixes to push, then I will start working on the Docker container running as non-root user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed code, all is well on my end. Ready to merge.