Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Docker Files #375

Merged
merged 5 commits into from
Jul 5, 2022
Merged

Added Docker Files #375

merged 5 commits into from
Jul 5, 2022

Conversation

vaughngx4
Copy link
Contributor

  • Added Docker Files(Initial Commit)
  • Have not yet logged in to run full tests - but everything runs

- Added Docker Files(Initial Commit)
- Fixed spelling of placeholders
- Added notification service to default set of vars
- Mirrored changes in docker init script to match
@vaughngx4
Copy link
Contributor Author

Fixed PHP config

@alexanderadam
Copy link

alexanderadam commented Jul 3, 2022

Woah, nice! Then only a GitHub action for automated builds, tags and pushes is needed to have official images, right?

@vaughngx4
Copy link
Contributor Author

@alexanderadam I presume so, yes :) there is some caching related code in the build script, I should probably comment that out.

- Commented out local registry caching
- Added normal build
- Added notary comments
@jon4short
Copy link
Contributor

Thank you so much, this is awesome work! I think I'll finally be able to use this.

I'd love to see a twitch stream with you testing it out.

Thanks Again!

@vaughngx4
Copy link
Contributor Author

@jon4short Glad I could help! I haven't had time to figure out creating a user just yet but I will definitely stream an explanation of the result and me testing it out. Actually just found an issue that will prevent mongo from working, will fix it now.

- Removed static init file
- Added init generation to docker build script
@vaughngx4
Copy link
Contributor Author

Should be sorted. Let me know if you guys run into any issues and I'll fix them as soon as I can.

- Fixed variable substitution
- Added generated init to .gitignore
@vaughngx4
Copy link
Contributor Author

Please can devs merge this PR, I have more changes to push.

If nobody is active enough, I don't mind handling things here. Otherwise I may have to look into making my fork a whole new SocioBoard replacement project.

@sureshbabu1995
Copy link
Collaborator

Please can devs merge this PR, I have more changes to push.

If nobody is active enough, I don't mind handling things here. Otherwise I may have to look into making my fork a whole new SocioBoard replacement project.

Hi sorry for the delay,

Thank you very much for support, Let me review it ASAP.

@vaughngx4
Copy link
Contributor Author

@sureshbabu1995 Thanks! Sorry for rushing you. Was beginning to think the project was abandoned. I understand there is a slight language barrier and I don't mind helping out. Will keep in touch.

@vaughngx4
Copy link
Contributor Author

After this PR merges I have the admin fixes to push, then I will start working on the Docker container running as non-root user.

Copy link
Contributor Author

@vaughngx4 vaughngx4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code, all is well on my end. Ready to merge.

@sureshbabu1995 sureshbabu1995 merged commit b3e6fba into socioboard:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants