-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support compression #1958
Support compression #1958
Conversation
I think socket.nocompress.emit('myevent'); |
Since I think it's fairly rare, a |
@@ -19,7 +19,7 @@ | |||
"test": "mocha --reporter dot --slow 200ms --bail" | |||
}, | |||
"dependencies": { | |||
"engine.io": "1.5.1", | |||
"engine.io": "Automattic/engine.io", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's point to a specific #commit
@@ -19,7 +19,7 @@ | |||
"test": "mocha --reporter dot --slow 200ms --bail" | |||
}, | |||
"dependencies": { | |||
"engine.io": "1.5.1", | |||
"engine.io": "Automattic/engine.io#ddc64a2d1286295fa7beaf2b113d6cbe4fbbc66b", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next time you can just use 7 digits.
Support compression and add the
compress
method which user can set thecompress
flag for a subsequent event emission.