Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default ingressClass cannot be used #43

Closed
jmnote opened this issue Oct 5, 2023 · 0 comments · Fixed by #44
Closed

Default ingressClass cannot be used #43

jmnote opened this issue Oct 5, 2023 · 0 comments · Fixed by #44

Comments

@jmnote
Copy link
Contributor

jmnote commented Oct 5, 2023 •
edited
Loading

Default ingressClass cannot be used.

varnish ingress (AS-IS)
https://github.com/softonic/varnish-chart/blob/0.18.6/templates/ingress.yaml#L15

spec:
  ingressClassName: {{ .Values.ingress.className }}

alertmanager ingress
https://github.com/prometheus-community/helm-charts/blob/alertmanager-1.7.0/charts/alertmanager/templates/ingress.yaml#L16-L18

spec:
  {{- if .Values.ingress.className }}
  ingressClassName: {{ .Values.ingress.className }}
  {{- end }}

prometheus ingress
https://github.com/prometheus-community/helm-charts/blob/alertmanager-1.6.0/charts/prometheus/templates/ingress.yaml#L26-L28

spec:
  {{- if and $ingressSupportsIngressClassName .Values.server.ingress.ingressClassName }}
  ingressClassName: {{ .Values.server.ingress.ingressClassName }}
  {{- end }}

See also:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add if block to ingressClassName to use default ingressClass
1 participant
@jmnote