Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add if block to ingressClassName to use default ingressClass #44

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Add if block to ingressClassName to use default ingressClass #44

merged 1 commit into from
Oct 23, 2023

Conversation

jmnote
Copy link
Contributor

@jmnote jmnote commented Oct 5, 2023 •
edited
Loading

What this PR does / why we need it

Add if block to ingressClassName to use default ingressClass

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer

See also:

Checklist

  • Chart Version bumped

@jmnote jmnote changed the title if-ingress-class-name Add if block to ingressClassName to use default ingressClass Oct 5, 2023
@bvis
Copy link
Member

bvis commented Oct 23, 2023

Thanks for your improvement!

@bvis bvis closed this Oct 23, 2023
@bvis bvis reopened this Oct 23, 2023
@bvis bvis merged commit 362055b into softonic:master Oct 23, 2023
@jmnote jmnote deleted the if-ingressclass branch October 23, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvis bvis bvis approved these changes

@santinoncs santinoncs Awaiting requested review from santinoncs santinoncs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default ingressClass cannot be used
2 participants
@jmnote @bvis