update rollout behaviour: #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we also add a switch in case external configmap is provided? Key We might "break" compatibility as this change would be the preferred way, but I think it would be good to have the possibility to restart pods on deploy when needed. |
- redeploy only if configmap content has changed (needs `rolloutDeployment: false`) - add switch to disable auto rollout on each upgrade.
OlivierCharuel
force-pushed
the
feature/changeRolloutBehaviour
branch
from
37f04f1
to
0bfb7d8
Compare
|
update rollout behaviour
|
|
Seems a reasonable change to me, thanks for your contribution. We can deprecate this behavior and disable it by default in a future release. (defaulting Functionality would keep working for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redeploy only if vcl configmap content has changed.