Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC: versioning from 0.1.0 #16

Closed
wants to merge 76 commits into from
Closed

BC: versioning from 0.1.0 #16

wants to merge 76 commits into from

Conversation

tebaly
Copy link

@tebaly tebaly commented Oct 27, 2021

auto build and publish OCI + GitLab pages

BC:

  • image.tag values
  • versioning from 0.1.0

FIX:

  • add env.secrets values
  • PodDisruptionBudget v1
  • ingress v1
  • tagPrefix version without "v"
  • gitlab-ci

@rccrdpccl
Copy link
Contributor

Thanks for your contribution! Unfortunately at the moment this PR cannot be merged as it is: there are parts that could be merged, parts that could be improved and merged, and parts that we cannot merge at present time.

If broken up, we will be willing to merge:

  • change apiversion/specs of Ingress
  • changes apiversion of PDB
  • adding secrets to deployment
  • change how we reference deployment's image

If you open separate PRs about the above changes (the first two and last two can be grouped together), we are willing to review them and merge.

Unfortunately the CI change is not in line with our standards (we have our own chartmuseum at the moment).
Do you see any reason why we should publish OCI image instead?

We would be willing to accept a PR on CI if it'd go towards our standards, or give us enough reason to change them.

@bvis
Copy link
Member

bvis commented Jun 27, 2022

I'll close this PR, amazing proposal but unresponsive for a long time. @tebaly we'll be glad for future collaborations

@bvis bvis closed this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants