Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix erroneous line feed in varnish.image. #36

Conversation

pgarrett-twc
Copy link

@pgarrett-twc pgarrett-twc commented Apr 5, 2023

This removes an unwanted line feed that appears when imageFullnameOverride is not provided. The extra line feed causes the problem:

[ERROR] templates/deployment.yaml: unable to parse YAML: error converting YAML to JSON: yaml: line 41: could not find expected ':'

Before

% helm template . --debug 2>&1 | grep -A2 image:
          image:
varnish:7.2.1
          imagePullPolicy: IfNotPresent
--
          image:
varnish:7.2.1
          imagePullPolicy: IfNotPresent

After

% helm template . --debug 2>&1 | grep -A2 image:
          image: varnish:7.2.1
          imagePullPolicy: IfNotPresent
          env:
--
          image: varnish:7.2.1
          imagePullPolicy: IfNotPresent
          command:

This removes an unwanted line feed that appears when
`imageFullnameOverride` is _not_ provided.

**Before**
```
% helm template . --debug 2>&1 | grep -A2 image:
          image:
varnish:7.2.1
          imagePullPolicy: IfNotPresent
--
          image:
varnish:7.2.1
          imagePullPolicy: IfNotPresent
```

**After**
```
% helm template . --debug 2>&1 | grep -A2 image:
          image: varnish:7.2.1
          imagePullPolicy: IfNotPresent
          env:
--
          image: varnish:7.2.1
          imagePullPolicy: IfNotPresent
          command:
```
@bvis
Copy link
Member

bvis commented May 23, 2023

I think this is already fixed in the last version of the package. Could you check the v0.14.1, please?

@bvis bvis closed this Jun 2, 2023
@bvis
Copy link
Member

bvis commented Jun 2, 2023

I'm closing this. If the problem persists, please open this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants