update pods on vcl file change #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Basilio Vera <basilio.vera@softonic.com>
bvis
commented
Oct 31, 2023
| {{- range $filename, $fileContent := .Values.vcl }} | ||
| {{ $filename }}:{{- toYaml $fileContent | indent 2 }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- if .Values.vclFiles }} |
bvis
commented
Oct 31, 2023
There was a problem hiding this comment.
Providing more useful values for testing
bvis
commented
Oct 31, 2023
There was a problem hiding this comment.
This is an example VCL that can be used for test the chart
santinoncs
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
In case you want to use a file for providing the VCL configuration this is not used for calculating the ConfigMap checksum, therefore the pods are not restarted.
Special notes for your reviewer
Checklist