Fix ambient attrs propagated to the generated Key struct #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veetaha
changed the title
|
Thanks for doing the work on this. I'll try to publish a release this weekend |
|
@Veetaha a new version is now published |
|
Yup, thanks :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #121
How did you verify your change:
Added a test first (it doesn't compile on current version of dynomite)
What (if anything) would need to be called out in the CHANGELOG for the next release:
Fix for #121
Additional info
@softprops I would like to ask you to release the 0.10.0 version to crates.io because current
dynomiteuses an outdated version ofrusoto_dynamodbwhich conflicts with some other crates that depend on new version ofrusoto_dynamodb.You've mentioned this bug was the blocker for the release (#123 (comment)), so I suppose we can merge this and cut off
0.10.0oncrates.io?