[ReanimatedSwipeable] Create separate spring configs to avoid overwriting ones already being used
#3045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latekvo
changed the title
ReanimatedSwipeable] Create separate spring configs forReanimatedSwipeable] Create separate spring configs to avoid overwriting ones already being used.
latekvo
changed the title
ReanimatedSwipeable] Create separate spring configs to avoid overwriting ones already being used.ReanimatedSwipeable] Create separate spring configs to avoid overwriting ones already being used
j-piasecki
approved these changes
Aug 14, 2024
m-bert
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ReanimatedSwipeable>animateRow()used to use onespringConfigfor two separatewithSpringanimations.#3044 highlighted that this approach could cause issues.
Test plan
not applicable, no working repro was provided, and i couldn't reproduce this issue with different code either