Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change yarn format script name #3053

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Change yarn format script name #3053

merged 1 commit into from
Aug 22, 2024

Conversation

m-bert
Copy link
Contributor

@m-bert m-bert commented Aug 21, 2024

Description

Since we do support macOS now, I think that yarn format:apple suits better than format:ios.

Test plan

Run formatter I guess 🤷‍♀️

@m-bert m-bert requested a review from j-piasecki August 21, 2024 11:07
@m-bert m-bert merged commit f9e9db7 into main Aug 22, 2024
1 check passed
@m-bert m-bert deleted the @mbert/update-script branch August 22, 2024 12:39
@m-bert m-bert mentioned this pull request Aug 22, 2024
Merged
m-bert added a commit that referenced this pull request Aug 22, 2024
@m-bert
Fix lint-staged (#3060)
cd5f7bb 
## Description

#3053 changed `format` script. However, I forgot to update `lint-staged` hook, which now fails on commit.

## Test plan

Try to commit changes in `obj-c` files.
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Sep 23, 2024
Open
@yingbull yingbull mentioned this pull request Sep 28, 2024
Open
@Adam-1052189 Adam-1052189 mentioned this pull request Sep 28, 2024
Open
@Alaa-1074002 Alaa-1074002 mentioned this pull request Sep 29, 2024
Open
@ColeCoffman ColeCoffman mentioned this pull request Oct 2, 2024
Open
@santiko santiko mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-piasecki j-piasecki j-piasecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-bert @j-piasecki