Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Android, Fabric): jumping content with native header #2169

Merged
merged 66 commits into from
Jun 18, 2024
Merged

fix(Android, Fabric): jumping content with native header #2169

merged 66 commits into from
Jun 18, 2024

Commits on Jun 4, 2024

  1. Stash current changes with jni setup

    @kkafar
    kkafar committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    6b2e6da View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Play around with various ideas

    @kkafar
    kkafar committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    2a2e1bc View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Working PoC

    @kkafar
    kkafar committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    5c8fd35 View commit details
    Browse the repository at this point in the history

  2. Get access to font size!

    @kkafar
    kkafar committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    581cd7e View commit details
    Browse the repository at this point in the history

  3. Add missing callsite parameter

    @kkafar
    kkafar committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    fd86a96 View commit details
    Browse the repository at this point in the history

  4. Improve PoC by adding font-size param

    @kkafar
    kkafar committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    fd9b32f View commit details
    Browse the repository at this point in the history

  5. Take font size into consideration

    @kkafar
    kkafar committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    bdfc038 View commit details
    Browse the repository at this point in the history

  6. Cleanup custom toolbar

    @kkafar
    kkafar committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    1ff7f95 View commit details
    Browse the repository at this point in the history

  7. Remove native function from ScreenViewManager

    @kkafar
    kkafar committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    29a92f3 View commit details
    Browse the repository at this point in the history

  8. Partially cleanup package file

    @kkafar
    kkafar committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    8b445d8 View commit details
    Browse the repository at this point in the history

  9. Cleanup C++ code & move implementation back to header file 

    Could not get syntax highlighting working with implementation being
split to separate .cpp file... Decided navigating through code is more
important than this separation for now.
    @kkafar
    kkafar committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    ed0b6ca View commit details
    Browse the repository at this point in the history

  10. Format common/ C++ code

    @kkafar
    kkafar committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    342c27e View commit details
    Browse the repository at this point in the history

  11. Add ifdefs for Android implementation

    @kkafar
    kkafar committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    7d2c5d8 View commit details
    Browse the repository at this point in the history

  12. Cleanup library entrypoint files

    @kkafar
    kkafar committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    5ed1933 View commit details
    Browse the repository at this point in the history

  13. Move WEAK_THIS initialization to createViewManagers & ... 

    ... do not unnecessarily pass context to screen view managers

When WEAK_THIS has been initialized in `init` block it did not work (jni
function calls were failing) -- too early.
    @kkafar
    kkafar committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    aadfe60 View commit details
    Browse the repository at this point in the history

  14. Missing code comment & cleaup

    @kkafar
    kkafar committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    ecd33f6 View commit details
    Browse the repository at this point in the history

  15. Cleanup shadow nodes

    @kkafar
    kkafar committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    14b0724 View commit details
    Browse the repository at this point in the history

  16. Remove console log from Screen

    @kkafar
    kkafar committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    9df3744 View commit details
    Browse the repository at this point in the history

  17. Restore in apps directory

    @kkafar
    kkafar committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    b74618b View commit details
    Browse the repository at this point in the history

  18. More cleanup in java files

    @kkafar
    kkafar committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    1c1f8a0 View commit details
    Browse the repository at this point in the history

  19. Optimize imports

    @kkafar
    kkafar committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    81805f0 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2024

  1. Improve signature of getInstance method

    @kkafar
    kkafar committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    f8a251b View commit details
    Browse the repository at this point in the history

  2. Improve error message in C++ layer when receiving null instance

    @kkafar
    kkafar committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    29f6b16 View commit details
    Browse the repository at this point in the history

  3. Whitespaces in C++ code

    @kkafar
    kkafar committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    6997c26 View commit details
    Browse the repository at this point in the history

  4. Improve JVM code a bit more, nicer error messages

    @kkafar
    kkafar committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    f67ba5e View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary line setting support action bar on Activity 

    I believe I added this when I was trygin to exactly reproduce setup
steps in ScreenStackHeaderConfig, but this should not affect final
layotu and thus is unneeded.
    @kkafar
    kkafar committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    27c6ec9 View commit details
    Browse the repository at this point in the history

  6. Restore compiler warning flags

    @kkafar
    kkafar committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    35f41b7 View commit details
    Browse the repository at this point in the history

  7. Add static variable for font-unset value & cleanup in loggs

    @kkafar
    kkafar committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    5d9210a View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary library initialization code

    @kkafar
    kkafar committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    5221637 View commit details
    Browse the repository at this point in the history

  9. Include fbjni only on Android

    @kkafar
    kkafar committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    73e533f View commit details
    Browse the repository at this point in the history

  10. Cleanup imports

    @kkafar
    kkafar committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    55418d9 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Setup custom component descriptor for screen stack

    @kkafar
    kkafar committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    eb36e66 View commit details
    Browse the repository at this point in the history

  2. Add simple LRU cache for headerHeight computation

    @kkafar
    kkafar committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    61c42d1 View commit details
    Browse the repository at this point in the history

  3. Use HEADER_HEIGHT_CORRECTION global in custom header config descriptor

    @kkafar
    kkafar committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    f76a0d9 View commit details
    Browse the repository at this point in the history

  4. Handle headerShown: false

    @kkafar
    kkafar committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    fcc5415 View commit details
    Browse the repository at this point in the history

  5. Make HeaderHeightCacheEntry private

    @kkafar
    kkafar committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    8ea06ac View commit details
    Browse the repository at this point in the history

  6. Better naming & rnscreens namespace

    @kkafar
    kkafar committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    8e3362f View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Use initialized empty option instead of uninitialized option as retur… 

    …n value
    @kkafar
    kkafar committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    608a11c View commit details
    Browse the repository at this point in the history

  2. Use margin instead of setting header config size

    @kkafar
    kkafar committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    9884e83 View commit details
    Browse the repository at this point in the history

  3. Remove setup wiht screen stack header config component descriptor

    @kkafar
    kkafar committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    699015e View commit details
    Browse the repository at this point in the history

  4. Try out setup with setting margin

    @kkafar
    kkafar committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    f465673 View commit details
    Browse the repository at this point in the history

  5. Go back to padding solution

    @kkafar
    kkafar committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    51ebbb7 View commit details
    Browse the repository at this point in the history

  6. Update frame origin & height manually

    @kkafar
    kkafar committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    e90f57d View commit details
    Browse the repository at this point in the history

  7. Separate JVM implementation to separate class

    @kkafar
    kkafar committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    d3da357 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Working PoC with padding & keeping header height in node state

    @kkafar
    kkafar committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    c3aab0e View commit details
    Browse the repository at this point in the history

  2. Some comments for JVM implementation part

    @kkafar
    kkafar committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    175f49c View commit details
    Browse the repository at this point in the history

  3. Use std:cref

    @kkafar
    kkafar committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    02a58c6 View commit details
    Browse the repository at this point in the history

  4. Cleanup example a bit

    @kkafar
    kkafar committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    2c42d65 View commit details
    Browse the repository at this point in the history

  5. Restore Test42 as default

    @kkafar
    kkafar committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    8a638c4 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into @kkafar/attempt-to-fix-jumping-header

    @kkafar
    kkafar committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    dc73577 View commit details
    Browse the repository at this point in the history

  7. Add test header to new App.js

    @kkafar
    kkafar committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    fc701ef View commit details
    Browse the repository at this point in the history

  8. Remove leftover showcase code

    @kkafar
    kkafar committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    cc110c5 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. Rename HeaderCorrectionModes to FrameCorrectionModes & put it behind … 

    …rnscreens namespace
    @kkafar
    kkafar committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    3746958 View commit details
    Browse the repository at this point in the history

  2. Add verbose error message

    @kkafar
    kkafar committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    e3c2fd8 View commit details
    Browse the repository at this point in the history

  3. Cleanup debug logging

    @kkafar
    kkafar committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    8fb2709 View commit details
    Browse the repository at this point in the history

  4. Make compareFrameSizes inline

    @kkafar
    kkafar committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    5938d56 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Merge branch 'main' into @kkafar/attempt-to-fix-jumping-header

    @kkafar
    kkafar committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    359bc49 View commit details
    Browse the repository at this point in the history

  2. Use Float instead of raw float to accomodate for platform differences

    @kkafar
    kkafar committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    54463b4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into @kkafar/attempt-to-fix-jumping-header

    @kkafar
    kkafar committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    d31dd00 View commit details
    Browse the repository at this point in the history

  4. Remove merge artifact: App.js in old localisation

    @kkafar
    kkafar committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    c5e3c6e View commit details
    Browse the repository at this point in the history

  5. Make comparision equality weak

    @kkafar
    kkafar committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    184a527 View commit details
    Browse the repository at this point in the history

  6. Set padding only if headerConfig child is present

    @kkafar
    kkafar committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    fbda22e View commit details
    Browse the repository at this point in the history

  7. Handle weird case when title is empty but there is custom font size

    @kkafar
    kkafar committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    cb6fe2b View commit details
    Browse the repository at this point in the history

  8. Add comment why 0.01 was chosen as default value for parameter

    @kkafar
    kkafar committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    db138f9 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Revert building example from source

    @kkafar
    kkafar committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    a0d15bb View commit details
    Browse the repository at this point in the history

  2. Revert disabling of headerTopInset

    @kkafar
    kkafar committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    4f34895 View commit details
    Browse the repository at this point in the history