-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exec_replace #658
Fix exec_replace #658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 The error you have been seeing seems to come from the subcommand spawn.
It seems that the script definition used there is just not runnable on windows. ( scarb/scarb/tests/subcommand.rs Line 144 in f8494ed
After changing the script definition, I was able to run it successfully and ensure it has been killed by ctrl_c.
May not be the cleanest flow, but imho worth considering. I have not been able to make this check work though. I do not understand what is the purpose of this.
I know it has been copied from Cargo verbatim. Maybe it is enough for now to only check if the process has been killed? cc @mkaput |
This check tests if the socket either closed successfully without any unread rubbish left in the buffer, or died by the second party being terminated.
I like this! I'd only rather use |
82cb6f7
to
52b2a92
Compare
Fix #125, Fix #129