Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cheerio import and yt scrape data #59

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

devansh-m12
Copy link
Contributor

@devansh-m12 devansh-m12 commented Oct 7, 2024

This fixes #58

here the proof :
Screenshot 2024-10-07 at 1 18 00 PM

Copy link

vercel bot commented Oct 7, 2024

@devansh-m12 is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@devansh-m12
Copy link
Contributor Author

We're already using Google's APIs to fetch YouTube playlists and videos, so why not use the same APIs to get the subscriber count instead of scraping the data, which avoids the uncertainties of updates?

@catalinred catalinred self-requested a review October 7, 2024 13:21
Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
solana-com ✅ Ready (Inspect) Visit Preview Oct 7, 2024 6:38pm

Copy link
Collaborator

@catalinred catalinred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @devansh-m12
This looks good overall, I added a couple of comments below

src/utils/followerFunctions.js Show resolved Hide resolved
src/utils/followerFunctions.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@catalinred catalinred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for working on it!

@devansh-m12
Copy link
Contributor Author

devansh-m12 commented Oct 7, 2024

@catalinred Thanks! On a separate note, the VK followers count isn't working, and it seems like much of the data in the community stats section is hardcoded. I'd be interested in working on that. and would it be possibe to add hactoberfest-accepted label on my pr

@catalinred
Copy link
Collaborator

@devansh-m12 I will have this branch merged next and fwiw I just added the #hacktoberfest topic label to this repo ;) I think this initiative is great, thanks for the suggestion.

Some of the community stats are hardcoded and could definitely use some attention. Feel free to open an issue or submit a PR, and we can continue the discussion there on how to address it.

@catalinred catalinred merged commit 1eb0232 into solana-foundation:main Oct 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: YouTube subscriber count displaying as zero on the Solana Community page
2 participants