-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cheerio import and yt scrape data #59
Conversation
@devansh-m12 is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
We're already using Google's APIs to fetch YouTube playlists and videos, so why not use the same APIs to get the subscriber count instead of scraping the data, which avoids the uncertainties of updates? |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @devansh-m12
This looks good overall, I added a couple of comments below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks for working on it!
@catalinred Thanks! On a separate note, the VK followers count isn't working, and it seems like much of the data in the community stats section is hardcoded. I'd be interested in working on that. and would it be possibe to add hactoberfest-accepted label on my pr |
@devansh-m12 I will have this branch merged next and fwiw I just added the #hacktoberfest topic label to this repo ;) I think this initiative is great, thanks for the suggestion. Some of the community stats are hardcoded and could definitely use some attention. Feel free to open an issue or submit a PR, and we can continue the discussion there on how to address it. |
This fixes #58
here the proof :