Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SnapshotPackagerService should push incremental snapshot hashes to CRDS #20441

Closed
Tracked by #20375
brooksprumo opened this issue Oct 5, 2021 · 1 comment · Fixed by #20442
Closed
Tracked by #20375

SnapshotPackagerService should push incremental snapshot hashes to CRDS #20441

brooksprumo opened this issue Oct 5, 2021 · 1 comment · Fixed by #20442
Assignees
@brooksprumo
Labels
locked issue

Comments

@brooksprumo
Copy link
Contributor

No description provided.

@brooksprumo brooksprumo mentioned this issue Oct 5, 2021
Closed
4 tasks
@brooksprumo brooksprumo self-assigned this Oct 5, 2021
brooksprumo added a commit to brooksprumo/solana that referenced this issue Oct 5, 2021
@brooksprumo
Push incremental snapshot hashes to CRDS
37d5588 
Now that CRDS supports incremental snapshot hashes,
SnapshotPackagerService needs to push 'em!

This commit does two main things:

1. SnapshotPackagerService now knows about incremental snapshot hashes,
   and will push SnapshotPackage::IncrementalSnapshot hashes to CRDS.
2. At startup, when loading from a full + incremental snapshot, the
   hashes need to be passed all the way to SnapshotPackagerService so it
   can push these starting hashes to CRDS.  Those values have been piped
   through.

Fixes solana-labs#20441 and solana-labs#20423
@brooksprumo brooksprumo mentioned this issue Oct 5, 2021
Merged
brooksprumo added a commit to brooksprumo/solana that referenced this issue Oct 8, 2021
@brooksprumo
Push incremental snapshot hashes to CRDS
a8c4dfa 
Now that CRDS supports incremental snapshot hashes,
SnapshotPackagerService needs to push 'em!

This commit does two main things:

1. SnapshotPackagerService now knows about incremental snapshot hashes,
   and will push SnapshotPackage::IncrementalSnapshot hashes to CRDS.
2. At startup, when loading from a full + incremental snapshot, the
   hashes need to be passed all the way to SnapshotPackagerService so it
   can push these starting hashes to CRDS.  Those values have been piped
   through.

Fixes solana-labs#20441 and solana-labs#20423
brooksprumo added a commit that referenced this issue Oct 8, 2021
@brooksprumo
SnapshotPackagerService pushes incremental snapshot hashes to CRDS (#…
5440c1d 
…20442)

Now that CRDS supports incremental snapshot hashes,
SnapshotPackagerService needs to push 'em!

This commit does two main things:

1. SnapshotPackagerService now knows about incremental snapshot hashes,
   and will push SnapshotPackage::IncrementalSnapshot hashes to CRDS.
2. At startup, when loading from a full + incremental snapshot, the
   hashes need to be passed all the way to SnapshotPackagerService so it
   can push these starting hashes to CRDS.  Those values have been piped
   through.

Fixes #20441 and #20423
dankelleher pushed a commit to identity-com/solana that referenced this issue Nov 24, 2021
@brooksprumo @dankelleher
SnapshotPackagerService pushes incremental snapshot hashes to CRDS (s…
0b266d2 
…olana-labs#20442)

Now that CRDS supports incremental snapshot hashes,
SnapshotPackagerService needs to push 'em!

This commit does two main things:

1. SnapshotPackagerService now knows about incremental snapshot hashes,
   and will push SnapshotPackage::IncrementalSnapshot hashes to CRDS.
2. At startup, when loading from a full + incremental snapshot, the
   hashes need to be passed all the way to SnapshotPackagerService so it
   can push these starting hashes to CRDS.  Those values have been piped
   through.

Fixes solana-labs#20441 and solana-labs#20423
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any activity in past 7 days after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brooksprumo brooksprumo

Labels
locked issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SnapshotPackagerService pushes incremental snapshot hashes to CRDS brooksprumo/solana
1 participant
@brooksprumo