Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token rpc endpoints to rpc-client #11315

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

CriesofCarrots
Copy link
Contributor

Problem

An spl-token CLI (solana-labs/solana-program-library#188) needs client methods for SPL token-specific RPC endpoints.

Summary of Changes

  • Add support for these token endpoints to rpc_client

@@ -992,11 +992,6 @@ fn verify_signature(input: &str) -> Result<Signature> {
.map_err(|e| Error::invalid_params(format!("Invalid param: {:?}", e)))
}

pub enum TokenAccountsFilter {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need access to this in solana-client

Copy link
Member

@mvines mvines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround

@mvines mvines added the v1.2 label Jul 31, 2020
@CriesofCarrots CriesofCarrots added the automerge Merge this Pull Request automatically once CI passes label Jul 31, 2020
@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2020

automerge label removed due to a CI failure

@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Jul 31, 2020
@CriesofCarrots CriesofCarrots added the automerge Merge this Pull Request automatically once CI passes label Jul 31, 2020
@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #11315 into master will decrease coverage by 0.0%.
The diff coverage is 10.8%.

@@            Coverage Diff            @@
##           master   #11315     +/-   ##
=========================================
- Coverage    82.5%    82.4%   -0.1%     
=========================================
  Files         316      316             
  Lines       74543    74618     +75     
=========================================
+ Hits        61504    61528     +24     
- Misses      13039    13090     +51     

@mergify mergify bot merged commit 9bcfc51 into solana-labs:master Jul 31, 2020
mergify bot pushed a commit that referenced this pull request Jul 31, 2020
(cherry picked from commit 9bcfc51)

# Conflicts:
#	client/src/rpc_client.rs
mergify bot added a commit that referenced this pull request Jul 31, 2020
* Add token rpc endpoints to rpc-client (#11315)

(cherry picked from commit 9bcfc51)

# Conflicts:
#	client/src/rpc_client.rs

* Fix conflicts

Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
Co-authored-by: Tyera Eulberg <tyera@solana.com>
@CriesofCarrots CriesofCarrots deleted the rpc-client-token branch September 1, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants