Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten docs publishing flow #12572

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Conversation

danpaul000
Copy link
Contributor

Problem

  • We are substituting in a release tag into the docs content based on the latest-in-time release on any branch. We should only sub in tags from the latest tag on the beta branch.
  • Docs publishing to docs.solana.com occurs when a tag is made on any branch, but this should only update docs.solana.com when a tag is made on beta branch.

Summary of Changes

  • Use ci/channel-info.sh to get latest beta tag, rather than querying github API.
  • Add a check to .travis.yml not to proceed with docs publishing if we are not on beta or edge channels.

Fixes #11505
Fixes #11387

@danpaul000
Copy link
Contributor Author

Commented out the "skip if PR" logic in .travis.yml to test logic. Will revert before merge.

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #12572 into master will decrease coverage by 7.6%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12572      +/-   ##
==========================================
- Coverage    82.0%    74.3%    -7.7%     
==========================================
  Files         356       31     -325     
  Lines       83140     1498   -81642     
  Branches        0      199     +199     
==========================================
- Hits        68197     1114   -67083     
+ Misses      14943      335   -14608     
- Partials        0       49      +49     

mvines
mvines previously approved these changes Sep 29, 2020
Copy link
Member

@mvines mvines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot dismissed mvines’s stale review September 30, 2020 15:56

Pull request has been modified.

Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@danpaul000 danpaul000 merged commit ede19ef into solana-labs:master Sep 30, 2020
@danpaul000 danpaul000 deleted the fix-rel-tag branch September 30, 2020 17:24
mergify bot pushed a commit that referenced this pull request Sep 30, 2020
(cherry picked from commit ede19ef)
mergify bot pushed a commit that referenced this pull request Sep 30, 2020
(cherry picked from commit ede19ef)
mergify bot added a commit that referenced this pull request Sep 30, 2020
(cherry picked from commit ede19ef)

Co-authored-by: Dan Albert <dan@solana.com>
mergify bot added a commit that referenced this pull request Sep 30, 2020
(cherry picked from commit ede19ef)

Co-authored-by: Dan Albert <dan@solana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs build process publishes on any branch tag set-solana-release-tag.sh does not stick to beta branch
3 participants