Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rustup default profile in travis ci mac image #18727

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

CriesofCarrots
Copy link
Contributor

Problem

Mac release artifacts are failing to build, due to rustfmt requirement in solana-storage-proto. The Travis CI rust image uses the minimal rustup profile, which doesn't include rustfmt.

Summary of Changes

Switch to default rustup profile

Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CriesofCarrots CriesofCarrots added the automerge Merge this Pull Request automatically once CI passes label Jul 16, 2021
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #18727 (4162cc5) into master (5f9f372) will decrease coverage by 11.6%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #18727       +/-   ##
===========================================
- Coverage    82.8%    71.1%    -11.7%     
===========================================
  Files         440       34      -406     
  Lines      124536     1979   -122557     
  Branches        0      278      +278     
===========================================
- Hits       103119     1408   -101711     
+ Misses      21417      475    -20942     
- Partials        0       96       +96     

@mergify mergify bot merged commit 2ec81f6 into solana-labs:master Jul 16, 2021
mergify bot pushed a commit that referenced this pull request Jul 16, 2021
(cherry picked from commit 2ec81f6)
mergify bot pushed a commit that referenced this pull request Jul 16, 2021
(cherry picked from commit 2ec81f6)
mergify bot added a commit that referenced this pull request Jul 16, 2021
(cherry picked from commit 2ec81f6)

Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
CriesofCarrots added a commit that referenced this pull request Jul 16, 2021
(cherry picked from commit 2ec81f6)

Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
@CriesofCarrots CriesofCarrots deleted the travis-mac-profile branch July 28, 2021 22:29
This was referenced Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants