Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add few more metrics data points #19624

Merged
merged 5 commits into from
Sep 15, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
correct the stats naming; fixes the dirty bit resetting
  • Loading branch information
tao-stones committed Sep 14, 2021
commit 8d283df1955fdbbb751b7f897cd9397f96f32d16
8 changes: 5 additions & 3 deletions core/src/cost_update_service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ impl CostUpdateServiceTiming {
let elapsed_ms = now - self.last_print;
if elapsed_ms > 1000 {
datapoint_info!(
"replay-service-timing-stats",
"cost-update-service-stats",
("total_elapsed_us", elapsed_ms * 1000, i64),
(
"update_cost_model_count",
Expand Down Expand Up @@ -101,15 +101,17 @@ impl CostUpdateService {
cost_update_receiver: CostUpdateReceiver,
) {
let mut cost_update_service_timing = CostUpdateServiceTiming::default();
let mut dirty = false;
let mut dirty: bool;
let mut update_count: u64;
let wait_timer = Duration::from_millis(100);

loop {
if exit.load(Ordering::Relaxed) {
break;
}

let mut update_count = 0_u64;
dirty = false;
update_count = 0_u64;
let mut update_cost_model_time = Measure::start("update_cost_model_time");
for cost_update in cost_update_receiver.try_iter() {
dirty |= Self::update_cost_model(&cost_model, &cost_update);
Expand Down