Pull channel functionality into record_stage #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes record_stage consistent with the other stages. The stage manages the channels. Anything else is in a standalone object. In the case of the record_stage, that leaves almost nothing!
willhickey
pushed a commit
that referenced
this pull request
Mar 16, 2024
Co-authored-by: Richard Patel <ripatel@jumptrading.com>
AshwinSekar
pushed a commit
to AshwinSekar/solana
that referenced
this pull request
Mar 16, 2024
Co-authored-by: Richard Patel <ripatel@jumptrading.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes record_stage consistent with the other stages. The stage
manages the channels. Anything else is in a standalone object.