Cleanup bank #277
Merged
Cleanup bank #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
History: Qualifying the method names with 'verified' was done to distinguish them from methods that first did signature verification. After we moved all signature verication to SigVerifyStage, we removed those methods from Bank, leaving only the 'verified' ones. This patch removes the word 'verified' from all method names, since it is now implied by any code running after SigVerifyStage.
History: the function was pulled out of Bank when each field wasn't wrapped in a RwLock, and that locking 'balances' meant to lock everything in the bank. Now that the RwLocks are here to stay, we can make it a method again.
History: we thought SigVerifyStage would use these, but it does signature verification before deserializing transactions.
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
==========================================
- Coverage 81.45% 81.34% -0.12%
==========================================
Files 30 30
Lines 3058 3039 -19
==========================================
- Hits 2491 2472 -19
Misses 567 567
Continue to review full report at Codecov.
|
This was referenced Dec 18, 2021
gregcusack
pushed a commit
to gregcusack/solana
that referenced
this pull request
Mar 19, 2024
cli: skip no-op program deploy write txs
willhickey
pushed a commit
that referenced
this pull request
Mar 20, 2024
cli: skip no-op program deploy write txs
apfitzge
referenced
this pull request
in apfitzge/agave
Mar 21, 2024
willhickey
pushed a commit
that referenced
this pull request
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.