Split vote related code from runtime to its own crate #32882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32882 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 785 785
Lines 212391 212445 +54
=======================================
+ Hits 174204 174252 +48
- Misses 38187 38193 +6 |
pgarg66
force-pushed
the
vote-crate
branch
2 times, most recently
from
37bf775
to
b769260
Compare
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
tao-stones
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The vote related code in runtime crate could be moved to its own crate. It'll help remove some unnecessary dependency on runtime crate and establish a cleaner interface between runtime and vote related code.
Summary of Changes
Move the vote code to its own crate and update imports.
Fixes #