visit_duplicate_pubkeys_during_startup uses scan #33397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
sp49
branch
from
2ec8f86
to
77df3b6
Compare
Codecov Report
@@ Coverage Diff @@
## master #33397 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 798 798
Lines 216579 216582 +3
=======================================
+ Hits 177481 177523 +42
+ Misses 39098 39059 -39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
working on speeding up startup.
generating the index takes a long time.
Summary of Changes
Change duplicate pubkey scan to use
scan(...), which is more efficient for iterating over many pubkeys.Be sure to hide whitespace changes for diff.
Fixes #