-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non-determinism in account_hash_ignore_slot on genesis #33692
Conversation
Codecov Report
@@ Coverage Diff @@
## master #33692 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 806 806
Lines 217676 217679 +3
=========================================
- Hits 178220 178200 -20
- Misses 39456 39479 +23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. But it might be worth confirming that this behaves correctly in case feature activation is scheduled in a future slot. (Which I believe is the second parameter of the tuple here (pubkey, _)
)
tuple.1 is the account itself. solana/sdk/src/genesis_config.rs Line 92 in a60d185
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
(cherry picked from commit 69495f4)
(cherry picked from commit 69495f4)
(cherry picked from commit 69495f4)
Problem
See #32801
until the
account_hash_ignore_slot
feature gets activated, there is some non-determinism in testing.Summary of Changes
Remove non-determinism.
Fixes #32800