cleanup feature code after mainnet-beta activation #34289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tao-stones
force-pushed
the
cleanup-feature-27500
branch
from
c59f118
to
b7a6668
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34289 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 819 819
Lines 219884 219759 -125
=========================================
- Hits 180263 180122 -141
- Misses 39621 39637 +16 |
apfitzge
reviewed
Nov 30, 2023
| @@ -5,8 +5,6 @@ type MicroLamports = u128; | |||
|
|
|||
| pub enum PrioritizationFeeType { | |||
There was a problem hiding this comment.
Do we plan to introduce more variants of prioritization in the near future?
If not, imo we should just get rid of this enum entirely.
There was a problem hiding this comment.
Yep, I agree. Didn't want to do it in "feature cleanup" PR. Would like to do it when this pr is merged. Given it's take some time before landing the cleanup PR, dont know what's the best way to remind myself to refactor tho 🤔
apfitzge
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
feature
EfhYd3SafzGT472tYQDUc4dPd2xdEfKs5fwkowUgVt4WRemove support for RequestUnitsDeprecated instruction #27500 activated everywhere.Summary of Changes
Fixes #