uses Merkle shreds in broadcast duplicates #35115
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35115 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 830 830
Lines 225031 225031
=========================================
- Hits 183748 183683 -65
- Misses 41283 41348 +65 |
behzadnouri
added
automerge
behzadnouri
force-pushed
the
merkle-duplicates
branch
from
09aef4f
to
869f2f9
Compare
| @@ -176,7 +176,7 @@ impl BroadcastRun for BroadcastDuplicatesRun { | |||
| None, // chained_merkle_root | |||
There was a problem hiding this comment.
can we use broadcast_utils::get_chained_merkle_root_from_parent( similar to the other stages? or saving that for a separate pr?
There was a problem hiding this comment.
That is done in #35058
But it is failing tests. So I extracted this out for now until the other one is debugged.
There was a problem hiding this comment.
the test is probably relying on being able to send a different last shred to different nodes and creating a separate valid version of the block. I'm assuming that no longer works with merkle shreds haha.
There was a problem hiding this comment.
can take a look at the test in the AM, this change looks fine to merge
| @@ -194,7 +194,7 @@ impl BroadcastRun for BroadcastDuplicatesRun { | |||
| None, // chained_merkle_root | |||
There was a problem hiding this comment.
similarly chaining this to the previous fec set
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
The commit migrates away from legacy shreds in duplicate shreds tests. (cherry picked from commit 7a95e4f)
Problem
Testing with legacy shreds is not good.
Summary of Changes
Use Merkle shreds in broadcast duplicates.