Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVM: Remove dependency on MatchAccountOwnerError #35144

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Feb 8, 2024

Problem

MatchAccountOwnerError being in accounts-db causes SVM to depend on accounts-db. This dependency must be removed to break SVM dep on accounts-db.

Summary of Changes

Use Option as the return value from the trait and impls.

Fixes #35096

Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works for me, thanks!

@pgarg66
Copy link
Contributor Author

pgarg66 commented Feb 8, 2024

this works for me, thanks!

Thanks for reviewing #35139. Current PR is certainly more concise.

@pgarg66 pgarg66 marked this pull request as ready for review February 8, 2024 14:28
@pgarg66 pgarg66 added the automerge Merge this Pull Request automatically once CI passes label Feb 8, 2024
@mergify mergify bot merged commit 9b63ac8 into solana-labs:master Feb 8, 2024
36 checks passed
@pgarg66 pgarg66 deleted the svm branch February 8, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVM: MatchAccountOwnerError is causing SVM to depend on accounts_db
4 participants