add validator catchup to multi-node test #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you move that to a separate test? And rename the original to something more precise. Monolithic catch-all tests are the worst. |
aeyakovenko
reviewed
Jun 25, 2018
tests/multinode.rs
Outdated
| if let Ok(bal) = client.poll_get_balance(&bob_pubkey) { | ||
| info!("validator balance {}", bal); | ||
| if bal == leader_balance { | ||
| success += 1; |
There was a problem hiding this comment.
I think you need to reset this to 0 if you are gong to rerun the loop
|
thanks, Stephen. my approach was to move leader creation farther up. this test is better, I think |
sakridge
force-pushed
the
validator-catchup-test
branch
from
eb3d491
to
e605ae0
Compare
sakridge
changed the title
aeyakovenko
reviewed
Jun 28, 2018
| leader.sockets.respond, | ||
| leader.sockets.gossip, | ||
| exit.clone(), | ||
| sink(), |
There was a problem hiding this comment.
I think we need to sink to tmp file, and let the validators restart from there.
There was a problem hiding this comment.
This is a confusing comment, since it's on the sink() line. When you say "sink to a tmp file", do you mean "sync to a tmp file"?
sakridge
force-pushed
the
validator-catchup-test
branch
from
e605ae0
to
7597d80
Compare
sakridge
force-pushed
the
validator-catchup-test
branch
from
7597d80
to
360b41e
Compare
garious
approved these changes
Jun 29, 2018
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
Bumps [eslint](https://github.com/eslint/eslint) from 7.8.1 to 7.9.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v7.8.1...v7.9.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
godmodegalactus
pushed a commit
to blockworks-foundation/solana
that referenced
this pull request
Jan 5, 2024
Use cluster info functions for tpu (solana-labs#345) (solana-labs#347) Use git rev-parse for git sha Remove blacklisted tx from message_hash_to_transaction (Backport solana-labs#374) (solana-labs#376) Updates scripts for easy local setup. (solana-labs#383) Backports sim_bundle improvements (solana-labs#407) backports clone derivation 416 (solana-labs#417) Backport solana-labs#419: add upsert to AccountOverrides (solana-labs#420) backports solana-labs#430 v1.16: update jito-programs sha (solana-labs#431) [JIT-1661] Faster Autosnapshot (solana-labs#406) Fix Buildkite warnings (solana-labs#437) Backport solana-labs#446 to v1.16 (solana-labs#447) backport 428, runtime plugin (solana-labs#429) v1.16: Backport solana-labs#449 (solana-labs#450)
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Apr 19, 2024
* runtime: Stakes::new: avoid extra loops over stakes.stake_delegations * runtime: parallelize Stakes::new with rayon * Address review comments * Address more comments
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Apr 19, 2024
* runtime: Stakes::new: avoid extra loops over stakes.stake_delegations * runtime: parallelize Stakes::new with rayon * Address review comments * Address more comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.