Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add "triangle" property to sd-container #737

Closed
4 of 12 tasks
karlbaumhauer opened this issue Feb 7, 2024 · 4 comments · Fixed by #776
Closed
4 of 12 tasks

feat: ✨ add "triangle" property to sd-container #737

karlbaumhauer opened this issue Feb 7, 2024 · 4 comments · Fixed by #776
Assignees
Labels
🔧 code needs changes in code 🎨 figma needs changes in Figma

Comments

@karlbaumhauer
Copy link
Contributor

karlbaumhauer commented Feb 7, 2024

User Story

As a user of the Solid Design System, I would like to add a visual triangle to the sd-container, so that I can easily rebuild the visual experience of the current ui-cms-text-infobox component.

Documentation

Figma Branch

Components detailed requirements

Props

Status Name Type Default Description
--triangle- left / right / top / bottom none define the position of the triangle cut-out

CSS-Properties

  • triangle-background - defines the background color of the triangle as the default is white and the container can be added on another background.

Stories

  • Triangle - shows the cut-out on each side.

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
@karlbaumhauer karlbaumhauer added 🎨 figma needs changes in Figma 🔧 code needs changes in code labels Feb 7, 2024
@karlbaumhauer
Copy link
Contributor Author

@coraliefeil pls add a respective Figma link as soon as you can provide something.

should we use this ticket for design as well or do you want to have another one?

@coraliefeil
Copy link
Contributor

Will do - thx. We can use this ticket here.

@karlbaumhauer
Copy link
Contributor Author

as discussed with the PO (Team CdA) today, @abudd1094 might be starting with this one in the next days. In case we dont have the design ready at this point, we might need to clarify the specs on the run.

The current cms component implementation can be used as design basis, as long as you will not be changing much. Maybe @coraliefeil you can have a look into it asap and let us know if the specs (size, color etc) will stay as currently implemented and then we will have more time to add the Figma component.

@coraliefeil coraliefeil self-assigned this Feb 7, 2024
@coraliefeil
Copy link
Contributor

Ready for pre-refinement.

@abudd1094 abudd1094 self-assigned this Feb 9, 2024
abudd1094 added a commit that referenced this issue Feb 28, 2024
closes #737 
Add triangle cut-out variant classes to container styles.
karlbaumhauer pushed a commit that referenced this issue Feb 28, 2024
# [@solid-design-system/components-v2.8.0](components/2.7.0...components/2.8.0) (2024-02-28)

### Features

* ✨ add sd container triangle property ([#776](#776)) ([cce15b7](cce15b7)), closes [#737](#737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 code needs changes in code 🎨 figma needs changes in Figma
Projects
Development

Successfully merging a pull request may close this issue.

3 participants