Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🤔 sd-dialog -> close icon missing after global-resources change #895

Closed
9 tasks
awacode21 opened this issue Mar 22, 2024 · 2 comments
Closed
9 tasks
Assignees

Comments

@awacode21
Copy link

Current behavior

the close icon of the close button within sd-dialog is not rendered:
Bildschirmfoto 2024-03-22 um 15 00 08

It looks like the library that is referenced is wrong:
Bildschirmfoto 2024-03-22 um 15 01 42
here it is referencing to global-resources, but as far as i understood it should reference library="default" instead. Then the icon would be shown.

Expected behavior

the close icon should be rendered so user can see the close option:
Bildschirmfoto 2024-03-22 um 15 00 47

Steps to reproduce

Reproduction: https://codepen.io/awacode/pen/MWxZNQE

Technical Information

All devices, All browsers

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
@mariohamann
Copy link
Contributor

Just to make that clear: it should point to library=system — this is the library we use internal in our components.

@awacode21
Copy link
Author

any plans when this will get fixed?

karlbaumhauer pushed a commit that referenced this issue Apr 17, 2024
# [@solid-design-system/components-v2.11.7](components/2.11.6...components/2.11.7) (2024-04-17)

### Bug Fixes

* use system icon in dialog ([4519180](4519180)), closes [#895](#895)
@mariohamann mariohamann self-assigned this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants