Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🤔 tabs do not grow with longer tab titles #904

Merged
merged 9 commits into from
Apr 11, 2024
Merged

fix: 🤔 tabs do not grow with longer tab titles #904

merged 9 commits into from
Apr 11, 2024

Conversation

Vahid1919
Copy link
Contributor

Description:

Closes #901

Definition of Reviewable:

PR notes: Irrelevant elements should be removed.

  • relevant tickets are linked

@Vahid1919 Vahid1919 linked an issue Apr 3, 2024 that may be closed by this pull request
fix: 🤔 tabs do not grow with longer tab titles #901
Closed
9 tasks
@Vahid1919 Vahid1919 requested review from a team April 3, 2024 10:32
@coraliefeil coraliefeil removed their assignment Apr 3, 2024
@van-nguyen-ht
Copy link
Contributor

Hi @Vahid1919 I left you some comments, here's the references

Screenshot 2024-04-03 at 13 22 42
Screen.Recording.2024-04-03.at.13.15.57.mov

@karlbaumhauer can I leave these materials here and delete when Vahid is done?

@karlbaumhauer
Copy link
Contributor

@karlbaumhauer can I leave these materials here and delete when Vahid is done?

@van-nguyen-ht as this does not contain any personal information, you can leave it here. helps us later to track the thicket.

@karlbaumhauer karlbaumhauer removed their assignment Apr 3, 2024
@Vahid1919
Copy link
Contributor Author

Hey @van-nguyen-ht
I pushed some updates. Please take a look at the new stories :)
I couldn't find a figma component with disabled icon tabs...should the color be neutral-400 as well?

@van-nguyen-ht
Copy link
Contributor

@Vahid1919 I can't add a photo in Chromatic so here's a screenshot of the No Line story for sd-tab-group
Screenshot 2024-04-08 at 15 49 34

@yoezlem yoezlem removed their assignment Apr 8, 2024
karlbaumhauer
karlbaumhauer approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@karlbaumhauer karlbaumhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from development side.

@yoezlem yoezlem mentioned this pull request Apr 9, 2024
Closed
9 tasks
@mariohamann mariohamann removed their assignment Apr 9, 2024
@van-nguyen-ht van-nguyen-ht removed their assignment Apr 10, 2024
@mariohamann
Copy link
Contributor

@coraliefeil @Vahid1919 @van-nguyen-ht Is there anything blocking left?

@Vahid1919
Copy link
Contributor Author

@mariohamann I just made the update from your review yesterday, which added a new screenshot for the parts story.
Waiting for approval from @solid-design-system/design

@Vahid1919 Vahid1919 merged commit 738e7c3 into main Apr 11, 2024
11 checks passed
@Vahid1919 Vahid1919 deleted the fix/tab-overflow branch April 11, 2024 08:11
karlbaumhauer pushed a commit that referenced this pull request Apr 11, 2024
@semantic-release-bot
chore(release/components): 2.11.3 [skip actions]
bf9910c 
# [@solid-design-system/components-v2.11.3](components/2.11.2...components/2.11.3) (2024-04-11)

### Bug Fixes

* 🤔 tabs do not grow with longer tab titles  ([#904](#904)) ([738e7c3](738e7c3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariohamann mariohamann mariohamann approved these changes

@karlbaumhauer karlbaumhauer karlbaumhauer approved these changes

@yoezlem yoezlem yoezlem approved these changes

Assignees

@mariohamann mariohamann

@Vahid1919 Vahid1919

@saemik94 saemik94

Labels
None yet
Projects
Solid Design System Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: 🤔 tabs do not grow with longer tab titles
8 participants
@Vahid1919 @van-nguyen-ht @karlbaumhauer @mariohamann @yoezlem @coraliefeil @saemik94 @EllaELSA