Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 sd-navigation-item remove default href + href when children #934

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

mariohamann
Copy link
Contributor

Description:

PR notes: Please describe the changes in this PR.

Definition of Reviewable:

PR notes: Irrelevant elements should be removed.

  • Documentation is created/updated
  • Migration Guide is created/updated
  • E2E tests (features, a11y, bug fixes) are created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

@mariohamann mariohamann marked this pull request as ready for review April 11, 2024 12:12
@mariohamann mariohamann changed the title fix: remove default href + href on accordion fix: 🐛 sd-navigation-item remove default href + href if accordion Apr 11, 2024
@mariohamann mariohamann changed the title fix: 🐛 sd-navigation-item remove default href + href if accordion fix: 🐛 sd-navigation-item remove default href + href when children Apr 11, 2024
@mariohamann mariohamann merged commit 554e9f7 into main Apr 12, 2024
11 checks passed
@mariohamann mariohamann deleted the fix/remove-href branch April 12, 2024 10:04
karlbaumhauer pushed a commit that referenced this pull request Apr 12, 2024
# [@solid-design-system/components-v2.11.5](components/2.11.4...components/2.11.5) (2024-04-12)

### Bug Fixes

* 🐛 sd-navigation-item remove default href + href when children ([#934](#934)) ([554e9f7](554e9f7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants