Convert grid classes in backend admin from skeleton to bootstrap #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! How about making the skeleton CSS optional -- perhaps an app has to add a |
harmonymjb
force-pushed
the
bootstrap_conversion
branch
from
87f744b
to
42ceb77
Compare
tvdeyen
reviewed
Sep 30, 2016
| @@ -1,6 +1,5 @@ | |||
| <div data-hook="admin_adjustment_reason_form_fields" class="row"> | |||
| <div class="row"> | |||
| <div class="alpha four columns"> | |||
| <div class="col-xs-3"> | |||
There was a problem hiding this comment.
I think you also want to correct the indenting here
There was a problem hiding this comment.
Thanks, rebased this commit: b1bb56fe6a42f28c95f731a591cf670659bde336
harmonymjb
force-pushed
the
bootstrap_conversion
branch
from
bbe8227
to
f481bef
Compare
jhawthorn
approved these changes
Oct 7, 2016
|
Amazing effort and excellent commit names & all! Thanks a lot! |
tvdeyen
approved these changes
Oct 12, 2016
added 21 commits
October 12, 2016 10:04
added 17 commits
October 12, 2016 10:05
harmonymjb
force-pushed
the
bootstrap_conversion
branch
from
f481bef
to
52dc71f
Compare
|
Thank you @omnistegan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains commits for all views within backend/app/views/spree that rely on skeleton grid classes.
This continues work on the Solidus admin roadmap #655 #1153 and allows the possibility of implementing the content-layout system introduced in #1114 by @graygilmore across any admin view without other modifications.
Each of these views have been updated using bootstrap grid classes and all skeleton classes have been removed. Layouts have not been significantly altered and no functionality has been added or removed.
Skeleton has been left enabled in order to maintain support for extensions that rely on it.
Because both skeleton and bootstrap implement a
rowclass, bootstrap inherits skeleton's additional vertical spacing onrow. This only affects bootstrap visually androws work as intended if bootstrap classes are used.Here is an example of an updated view, first with skeleton classes:
And with bootstrap classes:
