Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and improve stock locations form #1523

Merged
merged 2 commits into from
Oct 4, 2017

Conversation

jhawthorn
Copy link
Contributor

@jhawthorn jhawthorn commented Oct 13, 2016

This removes the cluttered layout of the existing form in favour of just having the fields from top to bottom. Fields are grouped into 3 logical sections.

This also adds informational hints to the settings checkboxes.

Before

After

@tvdeyen
Copy link
Member

tvdeyen commented Oct 14, 2016

Simpler it is. But I'm not sure if this is also optimal. But it's a good start to put this form either in an overlay/modal or use the space for some additional info.

👍 For the hints

I would like to here what @Mandily has to say

@Mandily
Copy link
Contributor

Mandily commented Oct 17, 2016

I also like the idea of the tooltips on the checkboxes. I don't completely understand what all of these are for, but I wonder if there's a way to group them up into something more meaningful for users? Do any of you have a pulse on that?

The stock locations page in the new layout would look something like this
stock locations

I know @omnistegan has been working on implementing the new layouts over the last couple of weeks. I wonder if we shouldn't wait at this point for those new layouts instead of reconfiguring stuff in skeleton.

Copy link
Member

@gmacdougall gmacdougall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favour of this. John is rebasing now to fix bootstrap upgrade related conflicts.

After that I'll give it 👍

@cbrunsdon cbrunsdon merged commit 6cf0c7b into solidusio:master Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants