Remove unused variable assignment from Admin::OrdersController#index action #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitbw
force-pushed
the
aitbw/remove-unnecessary-deletion
branch
from
35854d3
to
f8d2dd2
Compare
aitbw
changed the title
|
I think params here are restored so they can be presented to the user in the view again. If they are left empty user would lose the date that he/she entered before submitting, right? |
|
@kennyadsl oh snap, you're absolutely right! Sorry about that 🙇♀️ There's still this, that I think we can safely remove: |
This variable assignment was introduced back in commit 1a38331; since it is now unused and does not affect the code in any way, it can be safely removed
aitbw
force-pushed
the
aitbw/remove-unnecessary-deletion
branch
from
f8d2dd2
to
442fe04
Compare
aitbw
changed the title
jacobherrington
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This variable assignment was introduced back in commit 1a38331; since it is now unused and does not affect the code in any way, it can be safely removed
Checklist: