Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eval the custom Gemfile with file and line number #3204

Merged
merged 1 commit into from
May 13, 2019
Merged

Eval the custom Gemfile with file and line number #3204

merged 1 commit into from
May 13, 2019

Conversation

elia
Copy link
Member

@elia elia commented May 10, 2019 •
edited
Loading

Description
Errors in the custom gemfile will be reported at the right location

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

kennyadsl
kennyadsl approved these changes May 10, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elia !

tvdeyen
tvdeyen approved these changes May 10, 2019
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks

@elia elia marked this pull request as ready for review May 13, 2019 09:17
@kennyadsl kennyadsl merged commit 871d82a into solidusio:master May 13, 2019
@kennyadsl kennyadsl deleted the elia/gemfile-eval-location branch May 13, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elia @tvdeyen @kennyadsl