test/kubernetes/e2e: migrate helm tests (#10165)

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
solo-io · Oct 4, 2024 · 2aff8d7 · 2aff8d7
1 parent 3317101
commit 2aff8d7
Show file tree

Hide file tree

Showing 15 changed files with 167 additions and 923 deletions.
diff --git a/.github/workflows/pr-kubernetes-tests.yaml b/.github/workflows/pr-kubernetes-tests.yaml
@@ -78,7 +78,7 @@ jobs:
         # September 24, 2024: 22 minutes
         - cluster-name: 'cluster-five'
           go-test-args: '-v -timeout=25m'
-          go-test-run-regex: '^TestValidationStrict$$|^TestValidationAlwaysAccept$$|^TestTransformationValidationDisabled$$|^TestGloomtlsGatewayEdgeGateway$$|^TestHelm$$|^TestWatchNamespaceSelector$$'
+          go-test-run-regex: '^TestValidationStrict$$|^TestValidationAlwaysAccept$$|^TestTransformationValidationDisabled$$|^TestGloomtlsGatewayEdgeGateway$$|^TestHelm$$|^TestHelmSettings$$^TestWatchNamespaceSelector$$'
 
         # In our PR tests, we run the suite of tests using the upper ends of versions that we claim to support
         # The versions should mirror: https://docs.solo.io/gloo-edge/latest/reference/support/

diff --git a/.github/workflows/regression-tests.yaml b/.github/workflows/regression-tests.yaml
@@ -49,7 +49,7 @@ jobs:
         # upgrade tests are run on LTS but not on main branch, for main they are run nightly
         # ingress will be deprecated from 1.17. Ref: https://solo-io-corp.slack.com/archives/G01EERAK3KJ/p1716389614777799
         # this is the github action version of ternary op
-        kube-e2e-test-type: [ 'gateway', 'gloo', 'helm', 'upgrade' ]
+        kube-e2e-test-type: [ 'gateway', 'gloo', 'upgrade' ]
         kube-version: [ { node: 'v1.31.0@sha256:53df588e04085fd41ae12de0c3fe4c72f7013bba32a20e7325357a1ac94ba865', kubectl: 'v1.31.0', kind: 'v0.24.0', helm: 'v3.14.4' } ]
         image-variant:
           - distroless

diff --git a/changelog/v1.18.0-beta25/migrate-e2e-tests-part2.yaml b/changelog/v1.18.0-beta25/migrate-e2e-tests-part2.yaml
@@ -0,0 +1,5 @@
+changelog:
+  - type: NON_USER_FACING
+    issueLink:
+    description: >-
+      Remove kube2e/helm tests which are duplicated in our new e2e tests, and add a new test
diff --git a/test/kube2e/helm/artifacts/access-logging.yaml b/test/kube2e/helm/artifacts/access-logging.yaml
diff --git a/test/kube2e/helm/artifacts/custom-readiness-probe.yaml b/test/kube2e/helm/artifacts/custom-readiness-probe.yaml
diff --git a/test/kube2e/helm/artifacts/helm.yaml b/test/kube2e/helm/artifacts/helm.yaml
diff --git a/test/kube2e/helm/artifacts/horizontal-scaling.yaml b/test/kube2e/helm/artifacts/horizontal-scaling.yaml
diff --git a/test/kube2e/helm/artifacts/performance.yaml b/test/kube2e/helm/artifacts/performance.yaml
diff --git a/test/kube2e/helm/artifacts/safeguards.yaml b/test/kube2e/helm/artifacts/safeguards.yaml
diff --git a/test/kube2e/helm/artifacts/upgrade-override.yaml b/test/kube2e/helm/artifacts/upgrade-override.yaml
diff --git a/test/kube2e/helm/helm_suite_test.go b/test/kube2e/helm/helm_suite_test.go