error on storage client if name is not set

Signed-off-by: Scott Weiss <sdw35@cornell.edu>
solo-io · Jun 7, 2018 · 4c951ad · 4c951ad
1 parent 4fdc578
commit 4c951ad
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/pkg/storage/consul/client_template.go.tmpl b/pkg/storage/consul/client_template.go.tmpl
@@ -11,6 +11,9 @@ type {{ .LowercasePluralName }}Client struct {
 }
 
 func (c *{{ .LowercasePluralName }}Client) Create(item *v1.{{ .UppercaseName }}) (*v1.{{ .UppercaseName }}, error) {
+	if item.Name == "" {
+		return nil, errors.Errorf("name required")
+	}
 	out, err := c.base.Create(&base.StorableItem{{"{"}}{{ .UppercaseName }}: item})
 	if err != nil {
 		return nil, err
@@ -19,6 +22,9 @@ func (c *{{ .LowercasePluralName }}Client) Create(item *v1.{{ .UppercaseName }})
 }
 
 func (c *{{ .LowercasePluralName }}Client) Update(item *v1.{{ .UppercaseName }}) (*v1.{{ .UppercaseName }}, error) {
+	if item.Name == "" {
+		return nil, errors.Errorf("name required")
+	}
 	out, err := c.base.Update(&base.StorableItem{{"{"}}{{ .UppercaseName }}: item})
 	if err != nil {
 		return nil, err

diff --git a/pkg/storage/file/client_template.go.tmpl b/pkg/storage/file/client_template.go.tmpl
@@ -25,6 +25,9 @@ type {{ .LowercasePluralName }}Client struct {
 }
 
 func (c *{{ .LowercasePluralName }}Client) Create(item *v1.{{ .UppercaseName }}) (*v1.{{ .UppercaseName }}, error) {
+	if item.Name == "" {
+		return nil, errors.Errorf("name required")
+	}
 	// set resourceversion on clone
 	{{ .LowercaseName }}Clone, ok := proto.Clone(item).(*v1.{{ .UppercaseName }})
 	if !ok {
@@ -53,6 +56,9 @@ func (c *{{ .LowercasePluralName }}Client) Create(item *v1.{{ .UppercaseName }})
 }
 
 func (c *{{ .LowercasePluralName }}Client) Update(item *v1.{{ .UppercaseName }}) (*v1.{{ .UppercaseName }}, error) {
+	if item.Name == "" {
+		return nil, errors.Errorf("name required")
+	}
 	if item.Metadata == nil || item.Metadata.ResourceVersion == "" {
 		return nil, errors.New("resource version must be set for update operations")
 	}