Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: rebalance pr-kubernetes-tests #10046

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

sam-heilbron
Copy link
Contributor

@sam-heilbron sam-heilbron commented Sep 16, 2024

Description

Re-balance the Kubernetes

Context

In #10026, the Kubernetes tests started to exceed the given 25 minute threshold. In Slack the team agreed to keep this as a hard limit, and introduce a new cluster to ensure tests complete quickly in CI.

In Slack, @jbohanon confirmed that we should remove the load_balances folder. This was introduced as a way to track the changes that were made. But since it hasn't been adopted by the team, we felt it was better to remove it.

Interesting decisions

I didn't try to re-balance the clusters perfectly. I can tune it more, but my goal was to add a new cluster and take load off the problematic clusters (one,two)

Testing steps

  • Inspect the Github action logs for cluster-one. Confirm that they complete in under 25 minutes
  • Inspect the Github action logs for cluster-five.

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added keep pr updated signals bulldozer to keep pr up to date with base branch work in progress signals bulldozer to keep pr open (don't auto-merge) labels Sep 16, 2024
Copy link

github-actions bot commented Sep 16, 2024

Visit the preview URL for this PR (updated for commit adb83a6):

https://gloo-edge--pr10046-sh-rebalance-kube-te-wuz6nfqc.web.app

(expires Mon, 23 Sep 2024 19:32:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@sam-heilbron sam-heilbron changed the title [WIP] .github/workflows: rebalance pr-kubernetes-tests .github/workflows: rebalance pr-kubernetes-tests Sep 16, 2024
@sam-heilbron sam-heilbron removed the work in progress signals bulldozer to keep pr open (don't auto-merge) label Sep 16, 2024
@soloio-bulldozer soloio-bulldozer bot merged commit 1715303 into main Sep 16, 2024
19 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the sh/rebalance-kube-tests branch September 16, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants