Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admindcli helper and test framework improvement (#9656) #10050

Merged

Conversation

andy-fong
Copy link
Contributor

@andy-fong andy-fong commented Sep 16, 2024

Description

While working on the test for https://github.com/solo-io/solo-projects/issues/5455, found an issue with GetSingleListenerFromDynamicListeners() in admincli where it would crash if the config_dump returns an empty array.

Also, when running focused tests, the docker containers is left behind.

API changes

Code changes

  • return error in GetSingleListenerFromDynamicListeners() if the config array is empty
  • check docker container no longer exists before finishing AfterEach()

CI changes

Docs changes

Context

Interesting decisions

Testing steps

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@solo-changelog-bot
Copy link

Issues linked to changelog:
#9656

@github-actions github-actions bot added keep pr updated signals bulldozer to keep pr up to date with base branch work in progress signals bulldozer to keep pr open (don't auto-merge) labels Sep 16, 2024
Copy link

github-actions bot commented Sep 16, 2024

Visit the preview URL for this PR (updated for commit 506bd37):

https://gloo-edge--pr10050-andyfong-admincli-he-aqu4t3ih.web.app

(expires Tue, 24 Sep 2024 21:29:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@andy-fong andy-fong removed the work in progress signals bulldozer to keep pr open (don't auto-merge) label Sep 18, 2024
@soloio-bulldozer soloio-bulldozer bot merged commit 69d2da1 into main Sep 18, 2024
19 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the andyfong/admincli-helper-and-test-framework-improvement branch September 18, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants