-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admindcli helper and test framework improvement (#9656) #10050
Merged
soloio-bulldozer
merged 9 commits into
main
from
andyfong/admincli-helper-and-test-framework-improvement
Sep 18, 2024
Merged
admindcli helper and test framework improvement (#9656) #10050
soloio-bulldozer
merged 9 commits into
main
from
andyfong/admincli-helper-and-test-framework-improvement
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues linked to changelog: |
github-actions
bot
added
keep pr updated
signals bulldozer to keep pr up to date with base branch
work in progress
signals bulldozer to keep pr open (don't auto-merge)
labels
Sep 16, 2024
nfuden
reviewed
Sep 16, 2024
Visit the preview URL for this PR (updated for commit 506bd37): https://gloo-edge--pr10050-andyfong-admincli-he-aqu4t3ih.web.app (expires Tue, 24 Sep 2024 21:29:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
sam-heilbron
approved these changes
Sep 16, 2024
nfuden
approved these changes
Sep 18, 2024
andy-fong
removed
the
work in progress
signals bulldozer to keep pr open (don't auto-merge)
label
Sep 18, 2024
soloio-bulldozer
bot
deleted the
andyfong/admincli-helper-and-test-framework-improvement
branch
September 18, 2024 20:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on the test for https://github.com/solo-io/solo-projects/issues/5455, found an issue with GetSingleListenerFromDynamicListeners() in admincli where it would crash if the config_dump returns an empty array.
Also, when running focused tests, the docker containers is left behind.
API changes
Code changes
CI changes
Docs changes
Context
Interesting decisions
Testing steps
Notes for reviewers
Checklist: