Validate Headers from API Key Metadata: add configuration flag #10117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheidkamp
added
the
work in progress
github-actions
bot
added
the
keep pr updated
|
Issues linked to changelog: |
|
Visit the preview URL for this PR (updated for commit 91e9d5e): https://gloo-edge--pr10117-sheidkamp-validate-a-2th4x0gc.web.app (expires Mon, 07 Oct 2024 17:07:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
sheidkamp
changed the title
sheidkamp
removed
the
work in progress
sam-heilbron
approved these changes
Sep 30, 2024
nfuden
approved these changes
Sep 30, 2024
sheidkamp
added a commit
that referenced
this pull request
Oct 2, 2024
Co-authored-by: changelog-bot <changelog-bot> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
sheidkamp
added a commit
that referenced
this pull request
Oct 2, 2024
Co-authored-by: changelog-bot <changelog-bot> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
sheidkamp
added a commit
that referenced
this pull request
Oct 2, 2024
Co-authored-by: changelog-bot <changelog-bot> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
skip_metadata_validationto ApiKey Authorization to indicate that we do not want to validate headers created from APIKey metadata in the dataplaneAPI changes
Add
skip_metadata_validationto ApiKey AuthorizationTesting steps
Will be included in
solo-projectsPR.Checklist: