Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Remove helm from nightly suite #10171

Merged
merged 2 commits into from
Oct 4, 2024
Merged

tests: Remove helm from nightly suite #10171

merged 2 commits into from
Oct 4, 2024

Conversation

davidjumani
Copy link
Contributor

Description

Followup to #10165

Removes the helm tests from the nightly run

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added keep pr updated signals bulldozer to keep pr up to date with base branch work in progress signals bulldozer to keep pr open (don't auto-merge) labels Oct 4, 2024
@davidjumani
Copy link
Contributor Author

/skip-ci

@davidjumani
Copy link
Contributor Author

/skip-ci

@davidjumani davidjumani removed the work in progress signals bulldozer to keep pr open (don't auto-merge) label Oct 4, 2024
sam-heilbron
sam-heilbron approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@sam-heilbron sam-heilbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of this!

@soloio-bulldozer soloio-bulldozer bot merged commit 92475c3 into main Oct 4, 2024
17 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the remove-helm-nightlies branch October 4, 2024 14:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Visit the preview URL for this PR (updated for commit ed88877):

https://gloo-edge--pr10171-remove-helm-nightlie-uru7ta3c.web.app

(expires Fri, 11 Oct 2024 15:00:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-heilbron sam-heilbron sam-heilbron approved these changes

@andy-fong andy-fong andy-fong approved these changes

Assignees
No one assigned
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidjumani @sam-heilbron @andy-fong