KRT for GG #10193
Open
KRT for GG #10193
+1,450
−1,035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenctl
reviewed
Oct 10, 2024
| pluginRegistry := s.k8sGwExtensions.CreatePluginRegistry(ctx) | ||
| rm := reports.NewReportMap() | ||
| r := reports.NewReporter(&rm) | ||
| podClient := kclient.New[*corev1.Pod](s.istioClient) |
There was a problem hiding this comment.
Suggested change
| podClient := kclient.New[*corev1.Pod](s.istioClient) | |
| podClient := kclient.NewFiltered[*corev1.Pod](s.istioClient, kclient.Filter{ | |
| ObjectTransform: kube.StripPodUnusedFields, | |
| }) |
This gets rid of ManagedFields which is large and almost definitely unused
stevenctl
reviewed
Oct 10, 2024
| if err != nil { | ||
| // This should never happen, try again? | ||
| return | ||
| kubeUpstreams := setupCollectionDynamic[glookubev1.Upstream]( |
There was a problem hiding this comment.
nit: the name to me indicates Upstream_Kube when it means the k8s resource. Would just upstreams be ok? Or rawUpstreams maybe?
stevenctl
reviewed
Oct 10, 2024
| upstreamSpecs, | ||
| ) | ||
| if len(warns) > 0 || len(errs) > 0 { | ||
| // FIXME |
There was a problem hiding this comment.
the old code just logged in this case
There was a problem hiding this comment.
There was a problem hiding this comment.
|
/kick-ci |
|
/kick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First drop of bringing KRT to GG.
In this PR, we accomplish the following high-level items:
Caveats:
As we only are taking on the ApiSnapshot generation in this pass, the "boundary" of the KRT system is fairly narrow.
This means that we still have controller-runtime driving proxy resyncs (in addition to any of the work done by KRT's dependency tracking)
Status for RouteOptions and VHostOptions used in more than 1 proxy does not work, see https://github.com/solo-io/solo-projects/issues/7044
Unit testing
The currently proxy_syncer component (and the xds_syncer that preceded it) had no actual unit tests due to the nature of the work it is doing.
This PR does not add any unit tests but we will address this in a follow up, see: https://github.com/solo-io/solo-projects/issues/7056
Garbage collection
We need to implement garbage collection for kube gw Proxies
API changes
Code changes
CI changes
Docs changes
Context
Interesting decisions
Testing steps
Notes for reviewers
Checklist: