tests: Fix flaky tests and cleanup leftover resources in tests #10198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keep pr updated
|
Visit the preview URL for this PR (updated for commit b68710a): https://gloo-edge--pr10198-cleanup-tests-cvboxxth.web.app (expires Thu, 17 Oct 2024 15:23:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
davidjumani
commented
Oct 10, 2024
Comment on lines
+48
to
+55
| err := s.testInstallation.Actions.Kubectl().ApplyFile(s.ctx, testdefaults.NginxPodManifest) | ||
| s.Assert().NoError(err) | ||
| // Check that test resources are running | ||
| s.testInstallation.Assertions.EventuallyPodsRunning(s.ctx, testdefaults.NginxPod.ObjectMeta.GetNamespace(), metav1.ListOptions{ | ||
| LabelSelector: "app.kubernetes.io/name=nginx", | ||
| }) | ||
|
|
||
| err = s.testInstallation.Actions.Kubectl().ApplyFile(s.ctx, validation.ExampleUpstream, "-n", s.testInstallation.Metadata.InstallNamespace) |
There was a problem hiding this comment.
This could fix a nightly failure where the upsteam is in a warning state since the endpoint is not present.
davidjumani
changed the title
davidjumani
removed
the
work in progress
nfuden
approved these changes
Oct 10, 2024
jenshu
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanup leftover resources in tests that can cause pollution.
Checklist: