Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to change http-echo image #10206

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Conversation

ashishb-solo
Copy link
Contributor

@ashishb-solo ashishb-solo commented Oct 12, 2024

Description

This is just a test to see if we can change the image used for our tests from kennship/http-echo to jmalloc/echo-server. See changelog for details.

CI passes successfully, so it doesn't seem like this change causes any harm. I was hoping that CI runs would be faster since this image is smaller than the previous one, but it does not appear to make any difference - compare to the times for CI to run on this pull request as an example and you can see that the times to run do not change much at all.

However, this change does still provide an improvement in that the new image supports HTTP/2 while the other previous image does not:

ashish@laptop5 ~/go/src/github.com/solo-io/gloo/test/kubernetes/e2e/features/tracing/testdata $ kubectl -n curl exec -it curl -- curl --http2 http-echo.http-echo.svc.cluster.local:3000
curl: (52) Empty reply from server
command terminated with exit code 52

ashish@laptop5 ~/go/src/github.com/solo-io/gloo/test/kubernetes/e2e/features/tracing/testdata $ kubectl -n curl exec -it curl -- curl http-echo.http-echo.svc.cluster.local:3000
{"path":"/","headers":{"host":"http-echo.http-echo.svc.cluster.local:3000","user-agent":"curl/7.83.1-DEV","accept":"*/*"},"method":"GET","body":{},"fresh":false,"hostname":"http-echo.http-echo.svc.cluster.local","ip":"::ffff:10.244.0.230","ips":[],"protocol":"http","query":{},"subdomains":["svc","http-echo","http-echo"],"xhr":false}

API changes

Code changes

CI changes

Change http-echo image to use jmalloc/echo-server instead

Docs changes

Context

Interesting decisions

Testing steps

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Oct 12, 2024
@ashishb-solo ashishb-solo marked this pull request as ready for review October 12, 2024 04:15
Copy link
Contributor

@nfuden nfuden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should also look at which tests coul use docker.io/istio/tcp-echo-server at some point. That being said this seems like a nice incremental bump

Copy link
Contributor

@sam-heilbron sam-heilbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change! There are a number of other references to this image that we are removing still in the codebase. How should we handle removing those from the codebase?

In our docs we refer to hashicorp/http-echo, and in some of our code (

httpEchoImage = "gcr.io/solo-test-236622/http-echo"
) we refer to some other images.

I'm good with this change as is, just wanted to raise the potential for additional improvements in this area

@soloio-bulldozer soloio-bulldozer bot merged commit 1c76c0b into v1.17.x Oct 16, 2024
17 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the change-http-echo-image branch October 16, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants