Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM] test adding slack notification for test summaries #10211

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[DNM] test adding slack notification for test summaries #10211

wants to merge 8 commits into from
+100 −0

Conversation

jbohanon
Copy link
Contributor

Description

API changes

Code changes

CI changes

Docs changes

Context

Interesting decisions

Testing steps

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added keep pr updated signals bulldozer to keep pr up to date with base branch work in progress signals bulldozer to keep pr open (don't auto-merge) labels Oct 17, 2024
@jbohanon
Copy link
Contributor Author

/skip-ci testing gha

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 7a32f65):

https://gloo-edge--pr10211-jbohanon-test-summar-plmyfbcz.web.app

(expires Thu, 24 Oct 2024 19:35:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

nfuden
nfuden reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@nfuden nfuden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the output, can we add the job / test name or something?
https://solo-io-corp.slack.com/archives/C0314KESVNV/p1729194404389549

.github/workflows/composite-actions/kubernetes-e2e-tests/action.yaml
@@ -37,6 +40,7 @@ runs:
shell: bash
run: make go-test
- name: Summarize tests
if: ${{ always() }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my summarize wasnt always before? woof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfuden nfuden nfuden left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch work in progress signals bulldozer to keep pr open (don't auto-merge)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbohanon @nfuden